Juan Hernandez has posted comments on this change.
Change subject: packaging: Updated backups folder creation
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
Just a minor comment inside.
....................................................
File packaging/fedora/spec/ovirt-engine.spec.in
Line 754: %dir %{engine_data}/scripts/plugins
Line 755: %{engine_data}/scripts/plugins/example_plugin_000.py*
Line 756:
Line 757: # Backups directory
Line 758: %dir %attr(-, %{engine_user}, %{engine_group}) %{engine_state}/backups
Are you sure that the directory needs to be owned by the "ovirt" user and
group? I think that the backups are mostly created by the root user, so no need
to have this owned by "ovirt". If it is not needed then it is better to have it
owned by root, as that makes it a bit more secure.
Line 759:
Line 760: %files setup-plugin-allinone
Line 761: %{engine_data}/scripts/plugins/all_in_one_100.py*
Line 762:
--
To view, visit http://gerrit.ovirt.org/7499
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e79b78f4448bbe5f20b4836983e916b60c06acd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
