Moti Asayag has posted comments on this change. Change subject: core: Maintain Java style for UpdateVdsActionParameters ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/37466/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java: Line 261: getStrippedVdsUniqueId(), Line 262: getParameters().getVdsPort(), Line 263: IsPending); Line 264: UpdateVdsActionParameters p = new UpdateVdsActionParameters(vds.getStaticData(), "", false); Line 265: p.setInstallHost(!IsPending); > but this is not javs style, but trying to maintain consistency in terms of it isn't part of this patch. Note the explicit change refers to UpdateVdsActionParameters, and not to any class which uses it. It can (and will) be suggested later-on on its own patch. Line 266: p.setReinstallOrUpgrade(!IsPending); Line 267: p.setAuthMethod(VdsOperationActionParameters.AuthenticationMethod.PublicKey); Line 268: if (vds.isFenceAgentsExist()) { Line 269: p.setFenceAgents(vds.getFenceAgents()); -- To view, visit http://gerrit.ovirt.org/37466 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icdf57cbffac354873bb37ef92944ba1de6b0c71c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
