Moti Asayag has posted comments on this change. Change subject: restapi: Report available errata for host ......................................................................
Patch Set 4: (5 comments) http://gerrit.ovirt.org/#/c/37436/4/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd: Line 5456: <xs:element name="severity" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 5457: <xs:element name="solution" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 5458: <xs:element name="summary" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 5459: <xs:element ref="packages" minOccurs="0" maxOccurs="1"/> Line 5460: <xs:element ref="host" minOccurs="0" maxOccurs="1"/> > Fix the indenting before merging: two spaces per level. Done Line 5461: </xs:sequence> Line 5462: </xs:extension> Line 5463: </xs:complexContent> Line 5464: </xs:complexType> Line 5471: <xs:appinfo> Line 5472: <jaxb:property name="KatelloErrata"/> Line 5473: </xs:appinfo> Line 5474: </xs:annotation> Line 5475: <xs:element ref="katello_erratum" minOccurs="0" maxOccurs="unbounded"/> > Put the anntoation inside the annotated element: Done Line 5476: </xs:sequence> Line 5477: </xs:extension> Line 5478: </xs:complexContent> Line 5479: </xs:complexType> Line 5488: <xs:appinfo> Line 5489: <jaxb:property name="Packages"/> Line 5490: </xs:appinfo> Line 5491: </xs:annotation> Line 5492: <xs:element ref="package" minOccurs="0" maxOccurs="unbounded"/> > Put the annotation inside the annotated element. Done Line 5493: </xs:sequence> Line 5494: </xs:complexType> Line 5495: Line 5496: <xs:complexType name="Package"> Line 5495: Line 5496: <xs:complexType name="Package"> Line 5497: <xs:sequence> Line 5498: <xs:element name="name" type="xs:string" minOccurs="0" maxOccurs="1"> Line 5499: </xs:element> > Consider using <xs:element... />. Done Line 5500: </xs:sequence> Line 5501: </xs:complexType> Line 5502: http://gerrit.ovirt.org/#/c/37436/4/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java: Line 541: private void addErrataForHostsFeature(Features features) { Line 542: Feature feature = new Feature(); Line 543: feature.setName("Host Errata"); Line 544: feature.setDescription("View available errata for hosts."); Line 545: features.getFeature().add(feature); > Consider adding the "Katello" name in the name and/or description. Done Line 546: } -- To view, visit http://gerrit.ovirt.org/37436 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad98a8066bd0f002cd58129ce583bc932afee8bc Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
