Moti Asayag has uploaded a new change for review. Change subject: engine: Use java naming convention for method argument ......................................................................
engine: Use java naming convention for method argument Change-Id: I28c29ae11c56d30d48ce9a4a741051d2f77af56a Signed-off-by: Moti Asayag <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java 1 file changed, 9 insertions(+), 9 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/11/37611/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java index 2177e15..2e54a66 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java @@ -250,7 +250,7 @@ return returnValue; } - private boolean updateExistingHost(VDS vds, boolean IsPending) { + private boolean updateExistingHost(VDS vds, boolean pending) { boolean returnValue = true; vds.setHostName(vds.getHostName()); vds.setPort(getParameters().getVdsPort()); @@ -260,10 +260,10 @@ getStrippedVdsUniqueId(), getStrippedVdsUniqueId(), getParameters().getVdsPort(), - IsPending); + pending); UpdateVdsActionParameters p = new UpdateVdsActionParameters(vds.getStaticData(), "", false); - p.setInstallHost(!IsPending); - p.setReinstallOrUpgrade(!IsPending); + p.setInstallHost(!pending); + p.setReinstallOrUpgrade(!pending); p.setAuthMethod(VdsOperationActionParameters.AuthenticationMethod.PublicKey); if (vds.isFenceAgentsExist()) { p.setFenceAgents(vds.getFenceAgents()); @@ -279,7 +279,7 @@ getStrippedVdsUniqueId(), getStrippedVdsUniqueId(), getParameters().getVdsPort(), - IsPending); + pending); CaptureCommandErrorsToLogger(rc, "RegisterVdsQuery::Register"); returnValue = false; @@ -294,7 +294,7 @@ return returnValue; } - private boolean registerNewHost(Guid vdsGroupId, boolean IsPending) { + private boolean registerNewHost(Guid vdsGroupId, boolean pending) { boolean returnValue = true; VdsStatic vds = new VdsStatic(getParameters().getVdsHostName(), @@ -312,10 +312,10 @@ getParameters().getVdsHostName(), getStrippedVdsUniqueId(), getParameters().getVdsPort(), - IsPending); + pending); AddVdsActionParameters p = new AddVdsActionParameters(vds, ""); - p.setPending(IsPending); + p.setPending(pending); VdcReturnValueBase ret = Backend.getInstance().runInternalAction(VdcActionType.AddVds, p); @@ -331,7 +331,7 @@ } else { log.info( "RegisterVdsQuery::Register - Registered a new VDS '{}' - Name: '{}', Hostname: '{}', UniqueID: '{}'", - IsPending ? "pending approval" : "automatically approved", + pending ? "pending approval" : "automatically approved", getParameters().getVdsName(), getParameters().getVdsHostName(), getStrippedVdsUniqueId()); -- To view, visit http://gerrit.ovirt.org/37611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I28c29ae11c56d30d48ce9a4a741051d2f77af56a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
