Yevgeny Zaspitsky has posted comments on this change. Change subject: core: Introduce postConstruct for commands ......................................................................
Patch Set 6: (2 comments) Sorry for the late comments... http://gerrit.ovirt.org/#/c/37599/6//COMMIT_MSG Commit Message: Line 21: we would: Line 22: Line 23: @Override Line 24: protected postConstruct() { Line 25: dbFacade.getVmDao... I'd prefer injecting VmDao itself rather than DbFacade Line 26: } Line 27: Line 28: Change-Id: Ic0686c430b5151eb227eefb49096a27161d87723 http://gerrit.ovirt.org/#/c/37599/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 226: * should be done here. It is ensured that all injected dependencies were injected at the time calling. Line 227: * Line 228: * @see PostConstruct Line 229: */ Line 230: @PostConstruct 1. Would that work for the sub-classes where we override the method? 2. Why do we need to override the method in the sub-classes? We can create any method with no params that returns void and put @PostConstruct on it. Then its name will be meaningful. That's commonly known practice (documented on @PostConstruct), why do we need our own rules for that? Line 231: protected void postConstruct() { Line 232: } Line 233: Line 234: protected List<SPMAsyncTaskHandler> initTaskHandlers() { -- To view, visit http://gerrit.ovirt.org/37599 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0686c430b5151eb227eefb49096a27161d87723 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
