Alona Kaplan has uploaded a new change for review. Change subject: webadmin: add waitForResult property to runMultipleAction ......................................................................
webadmin: add waitForResult property to runMultipleAction The waitForResult property is a flag to return the result after running the whole action and not just the can do action. Change-Id: Ia94ec1334f9d33fd74ac2c773a5ad1d25c82eb96 Signed-off-by: Alona Kaplan <[email protected]> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java 1 file changed, 16 insertions(+), 10 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/23/37723/1 diff --git a/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java b/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java index 9bc001e..a5237aa 100644 --- a/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java +++ b/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java @@ -487,13 +487,15 @@ * @param callback The callback to call after the operation happens. * @param state A state object. * @param showErrorDialog Should we show an error dialog? + * @param waitForResult a flag to return the result after running the whole action and not just the can do actions. */ public void runMultipleAction(final VdcActionType actionType, final List<VdcActionParametersBase> parameters, final IFrontendMultipleActionAsyncCallback callback, final Object state, - final boolean showErrorDialog) { - runMultipleAction(actionType, parameters, false, callback, state, showErrorDialog); + final boolean showErrorDialog, + final boolean waitForResult) { + runMultipleAction(actionType, parameters, false, callback, state, showErrorDialog, waitForResult); } /** @@ -508,7 +510,7 @@ final List<VdcActionParametersBase> parameters, final IFrontendMultipleActionAsyncCallback callback, final Object state) { - runMultipleAction(actionType, parameters, false, callback, state, true); + runMultipleAction(actionType, parameters, false, callback, state, true, false); } @@ -520,7 +522,7 @@ public void runMultipleAction(final VdcActionType actionType, final List<VdcActionParametersBase> parameters, final IFrontendMultipleActionAsyncCallback callback) { - runMultipleAction(actionType, parameters, callback, null, true); + runMultipleAction(actionType, parameters, callback, null, true, false); } /** @@ -530,7 +532,7 @@ */ public void runMultipleAction(final VdcActionType actionType, final List<VdcActionParametersBase> parameters) { - runMultipleAction(actionType, parameters, null, null, true); + runMultipleAction(actionType, parameters, null, null, true, false); } /** @@ -538,12 +540,14 @@ * @param actionType The type of action to perform. * @param parameters The parameters of the action. * @param showErrorDialog Should we show an error dialog? + * @param waitForResult a flag to return the result after running the whole action and not just the can do actions. */ public void runMultipleAction(final VdcActionType actionType, final List<VdcActionParametersBase> parameters, final IFrontendMultipleActionAsyncCallback callback, - final boolean showErrorDialog) { - runMultipleAction(actionType, parameters, callback, null, showErrorDialog); + final boolean showErrorDialog, + final boolean waitForResult) { + runMultipleAction(actionType, parameters, callback, null, showErrorDialog, waitForResult); } /** @@ -559,7 +563,7 @@ final boolean isRunOnlyIfAllCanDoPass, final IFrontendMultipleActionAsyncCallback callback, final Object state) { - runMultipleAction(actionType, parameters, isRunOnlyIfAllCanDoPass, callback, state, true); + runMultipleAction(actionType, parameters, isRunOnlyIfAllCanDoPass, callback, state, true, false); } /** @@ -570,13 +574,15 @@ * @param callback The callback to call when the operation completes. * @param state The state. * @param showErrorDialog Should we show an error dialog? + * @param waitForResult a flag to return the result after running the whole action and not just the can do actions. */ public void runMultipleAction(final VdcActionType actionType, final List<VdcActionParametersBase> parameters, final boolean isRunOnlyIfAllCanDoPass, final IFrontendMultipleActionAsyncCallback callback, final Object state, - final boolean showErrorDialog) { + final boolean showErrorDialog, + final boolean waitForResult) { VdcOperationCallbackList<VdcOperation<VdcActionType, VdcActionParametersBase>, List<VdcReturnValueBase>> multiCallback = new VdcOperationCallbackList<VdcOperation<VdcActionType, VdcActionParametersBase>, List<VdcReturnValueBase>>() { @@ -625,7 +631,7 @@ List<VdcOperation<?, ?>> operationList = new ArrayList<VdcOperation<?, ?>>(); for (VdcActionParametersBase parameter: parameters) { VdcOperation<VdcActionType, VdcActionParametersBase> operation = new VdcOperation<VdcActionType, - VdcActionParametersBase>(actionType, parameter, true, multiCallback); + VdcActionParametersBase>(actionType, parameter, !waitForResult, multiCallback); operationList.add(operation); } fireAsyncOperationStartedEvent(state); -- To view, visit http://gerrit.ovirt.org/37723 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia94ec1334f9d33fd74ac2c773a5ad1d25c82eb96 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
