Alon Bar-Lev has posted comments on this change. Change subject: aaa: add support for basic athentication ......................................................................
Patch Set 12: (1 comment) http://gerrit.ovirt.org/#/c/37299/12/backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/ExternalAuthServlet.java File backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/ExternalAuthServlet.java: Line 89: response.sendRedirect(request.getContextPath() + SSOUtils.LOGIN_PHASE4_URI); Line 90: } else if (credentials != null) { Line 91: request.getSession(true).setAttribute(SSOUtils.USER_CREDENTIALS, credentials); Line 92: response.sendRedirect(request.getContextPath() + SSOUtils.LOGIN_PHASE3_URI); Line 93: } else if (config.isEnforceNego()) { > Currently when user hits esc, we show the login screen/login.jsp oh, because it goes to the 404, I thought it will reach here. ok, leave it this way for now. sorry. Line 94: enforceNego(response); Line 95: } else { Line 96: response.sendRedirect(request.getContextPath() + SSOUtils.LOGIN_PHASE2_URI); Line 97: } -- To view, visit http://gerrit.ovirt.org/37299 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If09285f0e6cd8909f21aa7e88ae1a3c1a30763c2 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
