Piotr Kliczewski has posted comments on this change. Change subject: engine : Geo-rep config Vds Commands ......................................................................
Patch Set 8: (1 comment) Your changes looks good but please revert formatting changes in JsonrRpcVdsServer class. http://gerrit.ovirt.org/#/c/35972/8/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java: Line 115: @Override Line 116: public StatusOnlyReturnForXmlRpc shutdown(String vmId, String timeout, String message) { Line 117: JsonRpcRequest request = Line 118: new RequestBuilder("VM.shutdown").withParameter("vmID", vmId) Line 119: .withOptionalParameter("delay", timeout) Can you please change your formatter settings? You changed formatting in many places in this class. It is hard to understand where your changes are. Line 120: .withOptionalParameter("message", message) Line 121: .build(); Line 122: Map<String, Object> response = new FutureMap(this.client, request); Line 123: return new StatusOnlyReturnForXmlRpc(response); -- To view, visit http://gerrit.ovirt.org/35972 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I558ed18b94faae9d4b824c9de1fedda25ffc3f09 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
