Freddy Rolland has posted comments on this change.

Change subject: webadmin: Remove warning on adding Storage Domain
......................................................................


Patch Set 1:

(2 comments)

Fixed comments

http://gerrit.ovirt.org/#/c/37445/1//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: Remove warning message about uninitialized Data Center when adding a
Line 10: storage domain.
Line 11: 
Line 12: Bug-Url: https://bugzilla.redhat.com/1081577
> This should be part of the footer  - please remove the blank line below thi
Done
Line 13: 
Line 14: Change-Id: I2649992874687fa2ec85fc262cabfdfb332a142b


http://gerrit.ovirt.org/#/c/37445/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NewEditStorageModelBehavior.java
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NewEditStorageModelBehavior.java:

Line 13: import org.ovirt.engine.ui.uicommonweb.Linq;
Line 14: import org.ovirt.engine.ui.uicommonweb.dataprovider.AsyncDataProvider;
Line 15: import org.ovirt.engine.ui.uicommonweb.models.Model;
Line 16: 
Line 17: import java.util.List;
> Why move this?
Done
Line 18: 
Line 19: public class NewEditStorageModelBehavior extends StorageModelBehavior
Line 20: {
Line 21:     @Override


-- 
To view, visit http://gerrit.ovirt.org/37445
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2649992874687fa2ec85fc262cabfdfb332a142b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <[email protected]>
Gerrit-Reviewer: Ala Hino <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Amit Aviram <[email protected]>
Gerrit-Reviewer: Candace Sheremeta <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Fred Rolland <[email protected]>
Gerrit-Reviewer: Freddy Rolland <[email protected]>
Gerrit-Reviewer: Idan Shaby <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to