Shireesh Anjal has posted comments on this change.
Change subject: engine: Gluster server peer list command
......................................................................
Patch Set 10: (1 inline comment)
One important comment in-line.
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterServersListVDSCommand.java
Line 2:
Line 3: import
org.ovirt.engine.core.common.vdscommands.VdsIdVDSCommandParametersBase;
Line 4: import
org.ovirt.engine.core.vdsbroker.irsbroker.GlusterServersListReturnForXmlRpc;
Line 5:
Line 6: public class GlusterServersListVDSCommand<P extends
VdsIdVDSCommandParametersBase> extends AbstractGlusterBrokerCommand<P> {
You need to override getReturnStatus() and return glusterHosts.mStatus there.
Otherwise ProceedProxyReturnValue() can throw a NullPointerException.
Line 7:
Line 8: private GlusterServersListReturnForXmlRpc glusterHosts;
Line 9:
Line 10: public GlusterServersListVDSCommand(P parameters) {
--
To view, visit http://gerrit.ovirt.org/7242
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfacfdc5847e5d871da38d22b6b5efe86ea4d579
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <[email protected]>
Gerrit-Reviewer: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Selvasundaram <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
