Piotr Kliczewski has posted comments on this change. Change subject: events: VM status update ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/37758/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java: Line 183: for (String key: keys) { Line 184: VmDynamic vmDynamic = this.dao.get(Guid.createGuidFromString(key)); Line 185: int newStatus = (int) map.get(key); Line 186: VMStatus previousStatus = vmDynamic.getStatus(); Line 187: if (newStatus != previousStatus.getValue()) { > I would say this condition is redundant, Will remove Line 188: vmDynamic.setStatus(VMStatus.forValue(newStatus)); Line 189: this.dao.update(vmDynamic); Line 190: } Line 191: } -- To view, visit http://gerrit.ovirt.org/37758 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3fb17e714390d07b215f1251d18fca9195c38565 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
