Francesco Romani has posted comments on this change. Change subject: Add OS info reporting ......................................................................
Patch Set 6: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/28938/6/scripts/ovirt-osinfo File scripts/ovirt-osinfo: Line 5: Line 6: print 'distribution=%s' % info[0] Line 7: print 'version=%s' % info[1] Line 8: print 'codename=%s' % info[2] Line 9: print 'arch=%s' % platform.uname()[-1] It seems safer to count forward (platform.uname()[4]) and not backward, because if you count forward you're safe if new fields are added in the end. But this is very minor and I believe here the risk is very low. Line 10: print 'kernel=%s' % platform.release() -- To view, visit http://gerrit.ovirt.org/28938 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I682fd9683cf9e4b392ecd4824e4a9526bf7e5e59 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
