Moti Asayag has uploaded a new change for review. Change subject: Revert "engine: Change iteration to foreach (#849971)" ......................................................................
Revert "engine: Change iteration to foreach (#849971)" This reverts commit a11ea98b0ec411e8fdde6898a1ca02ebc40c13d2. Change-Id: Ia7f3648090329109838fd8f1dffd235579968b3e Signed-off-by: Moti Asayag <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateNetworkToVdsInterfaceCommand.java 1 file changed, 5 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/73/7573/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateNetworkToVdsInterfaceCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateNetworkToVdsInterfaceCommand.java index 2a3c94d..27cb297 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateNetworkToVdsInterfaceCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateNetworkToVdsInterfaceCommand.java @@ -164,11 +164,12 @@ // check that interface exists for (final VdsNetworkInterface i : getParameters().getInterfaces()) { - for (VdsNetworkInterface iface : interfaces) { - if (iface.getName().equals(i.getName())) { - updatedIface = iface; + updatedIface = LinqUtils.firstOrNull(interfaces, new Predicate<VdsNetworkInterface>() { + @Override + public boolean eval(VdsNetworkInterface x) { + return x.getName().equals(i.getName()); } - } + }); if (updatedIface == null) { addCanDoActionMessage(VdcBllMessages.NETWORK_INTERFACE_NOT_EXISTS); return false; -- To view, visit http://gerrit.ovirt.org/7573 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia7f3648090329109838fd8f1dffd235579968b3e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
