Alon Bar-Lev has posted comments on this change.

Change subject: aaa: Modify webadmin and userportal to use enginesso for 
authentication
......................................................................


Patch Set 23:

(1 comment)

http://gerrit.ovirt.org/#/c/36619/23/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/TicketUtils.java
File 
backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/TicketUtils.java:

Line 10: public class TicketUtils {
Line 11: 
Line 12:     private static TicketDecoder ticketDecoder;
Line 13: 
Line 14:     public static synchronized TicketDecoder getTicketDecoder() {
avoid sync and do double check to avoid synchronization?
Line 15:         if (ticketDecoder == null) {
Line 16:             ticketDecoder = buildDecoder();
Line 17:         }
Line 18:         return ticketDecoder;


-- 
To view, visit http://gerrit.ovirt.org/36619
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iff0aee9d0f5ee606ff7f397cab69017ca7d9df08
Gerrit-PatchSet: 23
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to