Yaniv Bronhaim has posted comments on this change. Change subject: core: set cluster for host registration if null ......................................................................
Patch Set 1: (4 comments) http://gerrit.ovirt.org/#/c/37842/1//COMMIT_MSG Commit Message: Line 8: Line 9: This patch handles a case were the default cluster for host registration Line 10: is not defined in vdc_options properly or the default cluster was Line 11: removed. Line 12: so should be in RegisterVdsQuery Line 13: In that case instead of a failure, he code will try to find first the Line 14: default cluster and if not found any other cluster. Line 15: Line 16: Change-Id: I5eda0fe04de8338a49000d62338717584518b153 Line 13: he s/he/the http://gerrit.ovirt.org/#/c/37842/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java: Line 320: // this may occur when the default cluster is removed Line 321: List<VDSGroup> clusters = getVdsGroupDAO().getAll(); Line 322: if (clusters.size() > 0) { Line 323: setVdsGroup(clusters.get(0)); Line 324: return true; this logic should be in RegisterVds I think and depend if the default cluster is not valid or not mentioned in the vdc_option table Line 325: } Line 326: log.error("AddVdsCommand: No default or valid cluster was found, host registration failed."); Line 327: return failCanDoAction(VdcBllMessages.VDS_CLUSTER_IS_NOT_VALID); Line 328: } Line 322: if (clusters.size() > 0) { Line 323: setVdsGroup(clusters.get(0)); Line 324: return true; Line 325: } Line 326: log.error("AddVdsCommand: No default or valid cluster was found, host registration failed."); better to mention also in audit log Line 327: return failCanDoAction(VdcBllMessages.VDS_CLUSTER_IS_NOT_VALID); Line 328: } Line 329: } Line 330: return true; -- To view, visit http://gerrit.ovirt.org/37842 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5eda0fe04de8338a49000d62338717584518b153 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
