Martin Betak has posted comments on this change. Change subject: engine: read 'interface' property on from HostDevListByCaps result ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/37385/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java: Line 1959: if (params.containsKey(VdsProperties.TOTAL_VFS)) { Line 1960: device.setTotalVirtualFunctions(Integer.parseInt(params.get(VdsProperties.TOTAL_VFS).toString())); Line 1961: } Line 1962: if (params.containsKey(VdsProperties.NET_INTERFACE_NAME)) { Line 1963: device.setNetworkInterfaceName(params.get(VdsProperties.NET_INTERFACE_NAME).toString()); > no chance for the key to be null ? As with all above properties, if vdsm sets the key, the value should not be null Line 1964: } Line 1965: Line 1966: // if the device is attached to running VM, the `vmId` property will be set Line 1967: if (entry.getValue().containsKey(VdsProperties.VM_ID)) { -- To view, visit http://gerrit.ovirt.org/37385 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4deae6a655fa1db96411a99a9189f975e3667dd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
