Allon Mureinik has posted comments on this change.
Change subject: engine: RunMultipleAction - supporting Run Only If All CanDo
Pass
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
I like the concept, but this patch currently represents dead code - you're
adding a new functionallity to the Backend that is never used.
Can this be squashed to the place that uses it, or will this over complicate
that patch?
also see minor issues inline.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunner.java
Line 85: }
Line 86:
Line 87: boolean canRunActions = true;
Line 88: if (isRunOnlyIfAllCanDoPass)
Line 89: {
please move this up to the previous line ("egyptian notation"), as to preserve
the class's conventions.
Line 90: for (VdcReturnValueBase value : returnValues) {
Line 91: if (!value.getCanDoAction()) {
Line 92: canRunActions = false;
Line 93: break;
Line 95: }
Line 96: }
Line 97:
Line 98: if (canRunActions)
Line 99: {
same here.
Line 100: ThreadPoolUtil.execute(new Runnable() {
Line 101: @Override
Line 102: public void run() {
Line 103: RunCommands();
--
To view, visit http://gerrit.ovirt.org/7287
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If8f249484a451be44d3286c865806c5f8364f74a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
