Nir Soffer has posted comments on this change.
Change subject: packaging: setup: asking about retriyng VG creation with force
option
......................................................................
Patch Set 6:
During customization use CTRL-D to abort.
Please specify the storage you would like to use (glusterfs, iscsi,
fc, nfs3, nfs4)[nfs3]: fc
The following luns have been found on the requested target:
[1] 3514f0c5447600351 30GiB XtremIO XtremApp
status: used, paths: 4 active
[2] 3514f0c5447600352 30GiB XtremIO XtremApp
status: used, paths: 4 active
[3] 3514f0c5447600353 30GiB XtremIO XtremApp
status: used, paths: 4 active
[4] 3514f0c5447600354 30GiB XtremIO XtremApp
status: used, paths: 4 active
Please select the destination LUN (1, 2, 3, 4) [1]: 3
The selected device is probably dirty.
Would you like to force VG creation (WARNING: it can destroy any
existing data on the specified device)
(Force, Abort)[Abort]?
This device is used, so why not explain this in the confirmation dialog?
Assuming that this device is used by a vg this should say:
The select device is used by vg xxxyyy
Assuming that vdsm report it as used, but there is no vg info, maybe this
is the case when the device has partition table on it. In this case
I would show something like this:
The select device is used.
Then the dialog should explain that:
To create a vg on this device, you must use Force. This will
destroy existing data on the device.
Note that the warning in your message is too long and does not wrap properly.
Can you show the flow when using a free device and when creating the vg failed?
--
To view, visit http://gerrit.ovirt.org/37845
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I496c34e6b9f0d84443a8d5bc68d77916be6cb504
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Lev Veyde <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Simone Tiraboschi <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
