Sahina Bose has posted comments on this change. Change subject: gluster: VDS Cmd - Gluster volume snapshot activate/de-activate ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/34807/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeActivateSnapshotVDSParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeActivateSnapshotVDSParameters.java: Line 10: Line 11: public GlusterVolumeActivateSnapshotVDSParameters(Guid serverId, Line 12: String volumeName, Line 13: String snapshotName, Line 14: boolean force) { > Actually force is required only in the case of Create and Activate actions, You could have overloaded constructors in GlusterVolumeSnapshotActionVDSParameters. By default, boolean would be false, so won't affect the other VDS commands. Just a suggestion Line 15: super(serverId, volumeName, snapshotName); Line 16: this.force = force; Line 17: } Line 18: -- To view, visit http://gerrit.ovirt.org/34807 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d2241f784c2903b8b2467b835775eee34e776f4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Nishanth Thomas <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
