Eldan Shachar has posted comments on this change. Change subject: core/restapi/webadmin: Support clearing the cluster's emulated machine ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/37115/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java: Line 103: getParameters().getVdsGroup().setEmulatedMachine(null); Line 104: } Line 105: Line 106: if (getParameters().isForceResetEmulatedMachine()) { Line 107: getParameters().getVdsGroup().setDetectEmulatedMachine(true); > no need to set EmulatedMachine to null as well? it's maybe safer to leave the original one until the new detection occurs, similar behavior in line 83 (*only the variable is null, DB may contain a value). All hosts are down when the reset occurs so when one of the hosts starts it should check the flag and update the emulatedMachine field. Line 108: } Line 109: Line 110: getVdsGroupDAO().update(getParameters().getVdsGroup()); Line 111: -- To view, visit http://gerrit.ovirt.org/37115 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e1f70cbbe46fa54edda3f0aa9e56bfd576b8266 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eldan Shachar <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Eldan Shachar <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
