Lior Vernia has posted comments on this change. Change subject: webadmin: cluster guide me datacenter ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/37763/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelCellTable.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelCellTable.java: Line 221: return; Line 222: } Line 223: Line 224: getListModel().setSelectedItems(null); Line 225: getListModel().setSelectedItem(null); > i guess it's not a problem since we usually (always?) use SINGLE mode for r Whenever the checkbox column is visible it's created as a radio button, see addCheckboxColumn(). However, some of these tables don't have a checkbox column (you can select/deselect by clicking almost anywhere on the row). It does look like a bug, I would speculate that most uses are in multi mode, and single usages might be less common flows? I think this fix is right though. Line 226: // Clear "IsSelected" Line 227: for (EntityModel entity : (List<EntityModel>) getListModel().getItems()) { Line 228: entity.setIsSelected(false); Line 229: } -- To view, visit http://gerrit.ovirt.org/37763 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifaafdd5593d3721b9e6a8b466b2ac186b18bd6fe Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
