Daniel Erez has posted comments on this change. Change subject: frontend: created instance image widget ......................................................................
Patch Set 15: (2 comments) http://gerrit.ovirt.org/#/c/36063/15/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/instanceimages/InstanceImagesEditor.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/instanceimages/InstanceImagesEditor.java: Line 41: Line 42: @Override Line 43: protected InstanceImageLineModel createGhostValue() { Line 44: InstanceImageLineModel lineModel = new InstanceImageLineModel(model); Line 45: // the getVm() is null on new VM - that is handled inside the line models maybe you can pass the current vm name (if already entered) to the disk model, so a disk alias could be suggested? Line 46: lineModel.initialize(null, model.getVm()); Line 47: return lineModel; Line 48: } Line 49: http://gerrit.ovirt.org/#/c/36063/15/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/InstanceImageLineModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/InstanceImageLineModel.java: Line 153: if (validate()) { Line 154: flush(); Line 155: List<EntityModel<DiskModel>> selectedDisks = getSelectedDisks(); Line 156: if (selectedDisks.size() == 1) { Line 157: // only 0 or 1 is allowed hmm, actually why is that? can we support multiple attach? Line 158: setDisk(selectedDisks.iterator().next().getEntity().getDisk()); Line 159: } Line 160: Line 161: getDiskModel().setEntity(this); -- To view, visit http://gerrit.ovirt.org/36063 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4bcaa1e40841aa12e64708ec82afdb9daec9fb7f Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
