Oved Ourfali has submitted this change and it was merged. Change subject: db: reformat views code using pgformatter ......................................................................
db: reformat views code using pgformatter Currently it is hard to review changes made in DB scripts The reason is lack of general formatting. For example, in views, there are many columns in the same row and when a column is added it is hard to track the change. That may lead to some problems and regressions after the changed code is merged. The following uses a opensource tool named pgFormatter http://sourceforge.net/projects/pgformatter/ to make our code more readable and friendly for reviews. Currently only engine and dwh views were changed Change-Id: I8c127f152c73f08ac8d7d6f9448d010235e9d3d2 Signed-off-by: emesika <[email protected]> --- M packaging/dbscripts/create_dwh_views.sql M packaging/dbscripts/create_views.sql 2 files changed, 3,687 insertions(+), 2,273 deletions(-) Approvals: Eli Mesika: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37896 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c127f152c73f08ac8d7d6f9448d010235e9d3d2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
