Martin Mucha has posted comments on this change. Change subject: engine: remove EnumTranslator null warning message ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/38007/1/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/EnumTranslator.java File frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/EnumTranslator.java: Line 20 Line 21 Line 22 Line 23 Line 24 > I don't understand enough about EnumTranslator, so I'll let you and Franta I understand that, and can imagine how that can be annoying and complicating work. But, I don't care about developer experience in this case. Translator is used for example for printing dialog titles. User opens dialog and get's: "N/A" message as a title? That's highly unacceptable for me. Sure, this is a bug. Bug this bug should be filled asap by fed up developer (via spammed console) rather than later by fed up customer. For that reason I'd like to see better solution, like mentioned N/A, unset constant in respective enum type. This is just an explanation why I did it, so others can think of proper fix. -- To view, visit http://gerrit.ovirt.org/38007 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87b0d08099909aabc12acb4582b15cbce70cded7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
