Michael Kublin has posted comments on this change. Change subject: core: Allow to attach V1 and V2 data domains to a DC 3.1 ......................................................................
Patch Set 4: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java Line 320: return true; Line 321: } Line 322: Set<StorageFormatType> supportedFormatsSet = Line 323: getSupportedStorageFormatSet(storagePool.getcompatibility_version()); Line 324: if (supportedFormatsSet.contains(storageDomain.getStorageFormat())) { Not relevant Line 325: return true; Line 326: } Line 327: addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_DOMAIN_FORMAT_ILLEGAL); Line 328: getReturnValue().getCanDoActionMessages().add( -- To view, visit http://gerrit.ovirt.org/7445 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2424b80ba914f3d83ec99f442970bc103232563a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches