Roy Golan has uploaded a new change for review. Change subject: core: call postConstruct in CloneVm ......................................................................
core: call postConstruct in CloneVm after the move to postConstruct in parent AddVm, the call to init the command was missing. this fixes the broken clone vm with disks Change-Id: I6b4f63d45c5cb244c773fbbd4c06e698e439b81d Bug-Url: https://bugzilla.redhat.com/1195152 Signed-off-by: Roy Golan <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CloneVmCommand.java 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/31/38131/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CloneVmCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CloneVmCommand.java index ada5dea..51176da 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CloneVmCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CloneVmCommand.java @@ -48,15 +48,18 @@ public CloneVmCommand(T parameters) { super(parameters); + } + @Override + protected void postConstruct() { + super.postConstruct(); oldVmId = getParameters().getVmId(); setVmName(getParameters().getNewName()); // init the parameters only at first instantiation (not subsequent for end action) - if (Guid.isNullOrEmpty(parameters.getNewVmGuid())) { + if (Guid.isNullOrEmpty(getParameters().getNewVmGuid())) { setupParameters(); } - } @Override -- To view, visit https://gerrit.ovirt.org/38131 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6b4f63d45c5cb244c773fbbd4c06e698e439b81d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
