Maor Lipchuk has posted comments on this change. Change subject: core: Add managed devices to OVF ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/38120/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfUpdateProcessHelper.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfUpdateProcessHelper.java: Line 98: Map<Guid, VmDevice> managedDeviceMap = vmBase.getManagedDeviceMap(); Line 99: if (managedDeviceMap == null) { Line 100: managedDeviceMap = new HashMap<>(); Line 101: } Line 102: List<VmDevice> devices = DbFacade.getInstance().getVmDeviceDao().getVmDeviceByVmId(vmBase.getId()); > this seems to add also unmanaged devices, which isn't intentent. Changed it to be with the same behaviour being done today in ExportVmCommand Line 103: for (VmDevice device : devices) { Line 104: managedDeviceMap.put(device.getDeviceId(), device); Line 105: } Line 106: } Line 99: if (managedDeviceMap == null) { Line 100: managedDeviceMap = new HashMap<>(); Line 101: } Line 102: List<VmDevice> devices = DbFacade.getInstance().getVmDeviceDao().getVmDeviceByVmId(vmBase.getId()); Line 103: for (VmDevice device : devices) { > disk device will be duplicated now, have you checked that import storage d yes, seems to work fine, didn't encountered any bugs yet Line 104: managedDeviceMap.put(device.getDeviceId(), device); Line 105: } Line 106: } Line 107: -- To view, visit https://gerrit.ovirt.org/38120 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0e912c9b2950f1461ae95f4704f18b818b83a3b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
