Tomas Jelinek has posted comments on this change. Change subject: userportal,webadmin: added possibility to have single selection attach disk widget ......................................................................
Patch Set 14: (1 comment) https://gerrit.ovirt.org/#/c/36062/14//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-12-10 13:19:10 +0100 Line 4: Commit: Tomas Jelinek <[email protected]> Line 5: CommitDate: 2015-02-13 11:49:22 +0100 Line 6: Line 7: userportal,webadmin: added possibility to have single selection attach disk widget > oh ok, now I get it :) so maybe simply disable 'edit' for attached disks an It has 3 problems: - we would have a duality in behavior - why would the attach disk behave differently than create if it does not have to? - the "remove + add" and just "edit" is a bit different. The remove + add adds the disk to the end of the list while the edit only edits the one selected not changing it's position - sometimes I want one, sometimes the other. This would artificially enforce only one option. (true at least until the reorder will be implemented which has not yet started... But also in that case the "edit" will save some steps) - the edit works also in situations like: OK, I have filled everything in the new VM dialog, going to save. Lets just check quickly if everything is correct. What was the interface of the disk Im attaching again? (without edit I would have to remember the name, click '+', click "attach", find the disk in the dialog, check the interface and than not save this new disk). Line 8: Line 9: Feature Page: http://www.ovirt.org/Features/Instance_Types Line 10: Line 11: Change-Id: I535480b9d5671eab8e8a569d1d27755c304cea1e -- To view, visit https://gerrit.ovirt.org/36062 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I535480b9d5671eab8e8a569d1d27755c304cea1e Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
