Martin Betak has posted comments on this change. Change subject: frontend: refactoring: Generify list models ......................................................................
Patch Set 22: (1 comment) https://gerrit.ovirt.org/#/c/32907/22/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java: Line 285: syntaxChecker = SyntaxCheckerFactory.createUISyntaxChecker( Line 286: (String) AsyncDataProvider.getInstance().getConfigValuePreConverted(ConfigurationValues.AuthenticationMethod)); Line 287: } Line 288: Line 289: entityModel = new EntityModel<E>() { > Good point, I didn't realize I could access these protected methods and tha Ok, please ignore my last comment :-) The latest patch breaks everything. The inner model needs to call the SearchableListModel methods otherwise the subclasses that rely on overriding those won't get called. Now the question is what to do about the entityChanging method that as you correctly pointed out has non-emtpy default impl and those 2 classes that override it EventListModel and ClusterNetworkListModel have different expectations regarding super. ClusterNetworkListModel doesn't call this super whereas EventListModel does ... Line 290: @Override Line 291: protected void onEntityChanged() { Line 292: SearchableListModel.this.onEntityChanged(); Line 293: } -- To view, visit https://gerrit.ovirt.org/32907 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00f1671a5839fe31b49ad0d1c99bad84e5f0c7c4 Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Jakub Niedermertl <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
