Allon Mureinik has posted comments on this change. Change subject: core: Add fk constraint on vm_interface_statistics ......................................................................
Patch Set 3: Code-Review+2 (1 comment) minor styling issue, other than that, seems fine. https://gerrit.ovirt.org/#/c/38170/3/packaging/dbscripts/upgrade/03_06_0930_add_delete_contraint_vm_interface_statistics.sql File packaging/dbscripts/upgrade/03_06_0930_add_delete_contraint_vm_interface_statistics.sql: Line 1: -- Remove leftovers of vm_interface_statistics orphan childs. Line 2: DELETE FROM vm_interface_statistics Line 3: WHERE id not in (SELECT id from vm_interface); Standards: Please capitalize NOT IN Line 4: -- To view, visit https://gerrit.ovirt.org/38170 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53cf2737ef91cf967c93990fcb237f6c4e12a8f8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
