Liron Aravot has posted comments on this change. Change subject: core: WIP : RemoveImageDisk - race when updating snapshots ovf (#828192) ......................................................................
Patch Set 14: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java Line 99: getCommandId())); Line 100: p.setEntityId(getParameters().getEntityId()); Line 101: return AsyncTaskManager.getInstance().CreateTask(AsyncTaskType.deleteImage, p); Line 102: } Line 103: in a separate patch http://gerrit.ovirt.org/#/c/7606 Line 104: private void removeImageFromDB() { Line 105: final DiskImage diskImage = getDiskImage(); Line 106: final List<Snapshot> updatedSnapshots; Line 107: final boolean shouldPerformOpOnVmSnapshots = !diskImage.isShareable(); -- To view, visit http://gerrit.ovirt.org/7482 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iccb44f1aa9d204477955343167133849a4146753 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
