Liron Aravot has uploaded a new change for review.

Change subject: core: mark command as Executed only after the endMethod runs. 
Longer description using lines' length under 72 chars.
......................................................................

core: mark command as Executed only after the endMethod runs.
Longer description using lines' length under 72 chars.

With multiple paragraphs if necessary.

Change-Id: I3b10352dc4e25e98a64082a71df4a9ced0dc28f1
Bug-Url: https://bugzilla.redhat.com/??????
Signed-off-by: [email protected] <[email protected]>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/98/38198/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
index 02fcb90..286e111 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
@@ -576,15 +576,15 @@
         boolean exceptionOccurred = false;
         try {
             if (isEndSuccessfully()) {
+                internalEndSuccessfully();
                 if (getCallBack() == null) {
                     setCommandStatus(CommandStatus.SUCCEEDED);
                 }
-                internalEndSuccessfully();
             } else {
+                internalEndWithFailure();
                 if (getCallBack() == null) {
                     setCommandStatus(CommandStatus.FAILED);
                 }
-                internalEndWithFailure();
             }
         } catch (RuntimeException e) {
             exceptionOccurred = true;


-- 
To view, visit https://gerrit.ovirt.org/38198
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3b10352dc4e25e98a64082a71df4a9ced0dc28f1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to