Dudi Maroshi has posted comments on this change. Change subject: core: no need for a new TX when saving host numa stats ......................................................................
Patch Set 1: (1 comment) I agree with open question bellow. https://gerrit.ovirt.org/#/c/38046/1//COMMIT_MSG Commit Message: I agree there is no need for TX on Numa statistics. I agree for the following reasons. 1. Numa statistics record is not business critical. 2. Numa statistics record saving is implemented in a stored procedure that is a transaction by default (as far as I understand PostGresql.) Opening a question, If we agree on the above for Numa statistics. Can we agree on the same reasons to clean us transactions in HostMonitoring::saveCpuStatisticsDataToDb() ? Line 1: Parent: 6270bbbf (engine: Append Numa dynamic data to static data) Line 2: Author: Roy Golan <[email protected]> Line 3: AuthorDate: 2015-02-18 15:32:57 +0200 Line 4: Commit: Roy Golan <[email protected]> -- To view, visit https://gerrit.ovirt.org/38046 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e6a136e7f4f2e85ed52e4e312074ec4a0c4927e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Dudi Maroshi <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
