Tal Nisan has posted comments on this change. Change subject: webadmin: StorageListModel: refactorig storage prepare for edit. ......................................................................
Patch Set 3: (3 comments) https://gerrit.ovirt.org/#/c/38128/3//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-02-19 13:55:17 +0200 Line 4: Commit: Amit Aviram <[email protected]> Line 5: CommitDate: 2015-02-26 10:58:46 +0200 Line 6: Line 7: webadmin: StorageListModel: refactorig storage prepare for edit. s/refactorig/refactoring Line 8: Line 9: As preparing storage for editing in StorageListModel has similiar logic Line 10: through File and Block storage and all of their types, and currently Line 11: there is a "prepare" method for each of those types- it is now Line 8: Line 9: As preparing storage for editing in StorageListModel has similiar logic Line 10: through File and Block storage and all of their types, and currently Line 11: there is a "prepare" method for each of those types- it is now Line 12: consolidated into each model, with the proper differences devided s/devided/divided Line 13: between the models. Line 14: Line 15: prepareStorageForEdit will replace all of these "prepareXstorageForEdit" Line 16: and let the proper model to do the rest of the work, devided through SAN and Line 12: consolidated into each model, with the proper differences devided Line 13: between the models. Line 14: Line 15: prepareStorageForEdit will replace all of these "prepareXstorageForEdit" Line 16: and let the proper model to do the rest of the work, devided through SAN and s/devided/divided Line 17: FILE storage types. Line 18: Line 19: Change-Id: I2bb2a4c142eb1fe2870dc00d0d8764a6c866f8a2 -- To view, visit https://gerrit.ovirt.org/38128 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bb2a4c142eb1fe2870dc00d0d8764a6c866f8a2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
