Omer Frenkel has posted comments on this change.
Change subject: core:Enable update for storage domain name(#851835)
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageDomainCommand.java
Line 45:
Line 46: // Allow change only to name field
Line 47: props.remove("storage_name");
Line 48: if (returnValue && props.size() > 0) {
Line 49: log.errorFormat("There was an attempt to update the
following fields although they are not allowed to be updated: {0}",
i would use warn here
Line 50: StringUtils.join(props, ","));
Line 51:
addCanDoActionMessage(VdcBllMessages.ERROR_CANNOT_CHANGE_STORAGE_DOMAIN_FIELDS);
Line 52: returnValue = false;
Line 53: }
--
To view, visit http://gerrit.ovirt.org/7598
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I77de69fb8bd28a3c2c1ec1a9be576cb7b4e9dd69
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
