Alona Kaplan has uploaded a new change for review. Change subject: webadmin: Showing the tooltip of the reason column ......................................................................
webadmin: Showing the tooltip of the reason column Change-Id: Ie63a98a880b67bdfdb6a57ad840f4f2efed9155c Signed-off-by: Alona Kaplan <[email protected]> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/ReasonColumn.java 1 file changed, 18 insertions(+), 16 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/03/38303/1 diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/ReasonColumn.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/ReasonColumn.java index bff31ee..144461c 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/ReasonColumn.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/ReasonColumn.java @@ -1,26 +1,28 @@ package org.ovirt.engine.ui.webadmin.widget.table.column; -import com.google.gwt.resources.client.ImageResource; import org.ovirt.engine.core.common.businessentities.Reasoned; +import org.ovirt.engine.ui.common.widget.table.column.AbstractSafeHtmlWithSafeHtmlTooltipColumn; +import org.ovirt.engine.ui.webadmin.ApplicationResources; -public class ReasonColumn<T extends Reasoned> extends AbstractWebAdminImageResourceColumn<T> { +import com.google.gwt.core.shared.GWT; +import com.google.gwt.safehtml.shared.SafeHtml; +import com.google.gwt.safehtml.shared.SafeHtmlUtils; +import com.google.gwt.user.client.ui.AbstractImagePrototype; + +public class ReasonColumn<T extends Reasoned> extends AbstractSafeHtmlWithSafeHtmlTooltipColumn<T> { + + ApplicationResources resources = GWT.create(ApplicationResources.class); @Override - public ImageResource getValue(T value) { - setTitle(value.getStopReason()); - if (value.getStopReason() != null && !value.getStopReason().trim().isEmpty()) { - return getApplicationResources().commentImage(); + public SafeHtml getTooltip(T reasoned) { + return SafeHtmlUtils.fromString(reasoned.getStopReason()); + } + + @Override + public SafeHtml getValue(T reasoned) { + if (reasoned.getStopReason() != null && !reasoned.getStopReason().trim().isEmpty()) { + return SafeHtmlUtils.fromTrustedString(AbstractImagePrototype.create(resources.commentImage()).getHTML()); } return null; - } - - @Override - public ImageResource getDefaultImage() { - return getApplicationResources().commentImage(); - } - - @Override - public String getDefaultTitle() { - return CONSTANTS.reasonLabel(); } } -- To view, visit https://gerrit.ovirt.org/38303 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie63a98a880b67bdfdb6a57ad840f4f2efed9155c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
