Maor Lipchuk has posted comments on this change. Change subject: Core: Prevent VM migration when SCSI reservation is used ......................................................................
Patch Set 2: (5 comments) https://gerrit.ovirt.org/#/c/37664/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDevice.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDevice.java: Line 84: isScsiReservationUsed > What about equals and hashcode, should they need to be regenerated? also /s/isScsiReservationUsed/scsiReservationUsed Line 133: setScsiReservationUsed Why add a new constructor, and not changing all the usages https://gerrit.ovirt.org/#/c/37664/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java: Line 732: ACTION_TYPE_FAILED_PASSTHROUGH_IS_DISABLED Please add those message also to : 1) frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties - For the user portal (If necessary) 2) frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties - For the webadmin 3) backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties - for tests (if necessary) https://gerrit.ovirt.org/#/c/37664/2/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskDaoDbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskDaoDbFacadeImpl.java: Line 147: } > Please add this to LunDiskRowMapper Please disregard my last comment. since this is a vm device then this probably better to left as it is, I would consider to re-factor this to a method to make it a one liner (only a style suggestion) https://gerrit.ovirt.org/#/c/37664/2/packaging/dbscripts/upgrade/03_06_0860_add_uses_scsi_reservation.sql File packaging/dbscripts/upgrade/03_06_0860_add_uses_scsi_reservation.sql: Line 1: is_using_scsi_reservation Please change the field name from "is_using..." to be simply using_.... /s/is_using_scsi_reservation/using_scsi_reservation Also Ithink that the default value should be false (not null) -- To view, visit https://gerrit.ovirt.org/37664 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia38c03dae04c9dbb30c882941391b1909f5af416 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ala Hino <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Candace Sheremeta <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
