Martin Mucha has posted comments on this change. Change subject: core: added missing logging + refactoring ......................................................................
Patch Set 16: (1 comment) https://gerrit.ovirt.org/#/c/29244/16/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java: Line 62: } Line 63: } Line 64: Line 65: public static String getMessage(AuditLogType logType) { Line 66: return messages.get(logType); > This is waaay too old change to remember anything about it. But: I rechecked it, and in follow up patch it gets corrected so it returns "" on missing resource, while this method "dies" anyway. And missing resource problem is logged. So it's super easy return "" here and everything should be fine. Done. Line 67: } Line 68: Line 69: public static void log(AuditLogableBase auditLogable) { Line 70: AuditLogType logType = auditLogable.getAuditLogTypeValue(); -- To view, visit https://gerrit.ovirt.org/29244 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic737ace1808e1f242d0eb08ee458869a89be500e Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
