Omer Frenkel has posted comments on this change.
Change subject: core: cleanup MigrateVmCommand
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
Line 144: if (getSucceeded()) {
Line 145: return (VMStatus) getActionReturnValue() == VMStatus.Up ?
AuditLogType.VM_MIGRATION_DONE
Line 146: : AuditLogType.VM_MIGRATION_START;
Line 147: }
Line 148: if (getActionReturnValue() == VMStatus.MigratingFrom) {
this 'if' wasn't in the original code,
why is needed?
Line 149: return AuditLogType.VM_MIGRATION_START;
Line 150: }
Line 151: if (_isRerun) {
Line 152: return AuditLogType.VM_MIGRATION_TRYING_RERUN;
--
To view, visit http://gerrit.ovirt.org/7552
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8630df3887bc668edb2d34eb73d0295ae5289818
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
