Moti Asayag has posted comments on this change.
Change subject: core: Add null/empty support to IP Address pattern (#852076)
......................................................................
Patch Set 2: (2 inline comments)
Applied kolesnik comments, also added several other cases to be tested.
....................................................
File
backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/IPAddressPatternTest.java
Line 28:
Line 29: @Test
Line 30: public void checkIPAdress() {
Line 31: Set<ConstraintViolation<IPAdress>> validate =
validator.validate(new IPAdress(address));
Line 32: assertEquals(validate.isEmpty(), expectedResult);
Done
Line 33: }
Line 34:
Line 35: @Parameterized.Parameters
Line 36: public static Collection<Object[]> ipAddressParams() {
Line 40: { "192.168.1.1", true },
Line 41: { "10.10.1.1", true },
Line 42: { "127.0.0.1", true },
Line 43: { "", true },
Line 44: { null, true },
Done
Line 45: { "10.10.10", false },
Line 46: { "10.10", false },
Line 47: { "10", false },
Line 48: { "...", false },
--
To view, visit http://gerrit.ovirt.org/7634
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If8d38ebf880c72d86f956f7c08aefa12e1894109
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
