Eli Mesika has posted comments on this change.

Change subject: engine,webadmin: [WIP] Add an indicator if geo-replication is 
enabled
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/38310/1/packaging/dbscripts/create_views.sql
File packaging/dbscripts/create_views.sql:

Line 2994: SELECT
Line 2995:     gluster_volumes.*,
Line 2996:     vds_groups.name AS vds_group_name,
Line 2997:     CASE WHEN EXISTS (SELECT session_id FROM gluster_georep_session 
WHERE master_volume_id = gluster_volumes.id) THEN true
Line 2998:          ELSE false END 
please remove TWS
Line 2999:          as is_master,
Line 3000:     CASE WHEN EXISTS (SELECT session_id FROM gluster_georep_session 
WHERE slave_volume_id = gluster_volumes.id) THEN true
Line 3001:          ELSE false END 
Line 3002:          as is_slave


Line 2997:     CASE WHEN EXISTS (SELECT session_id FROM gluster_georep_session 
WHERE master_volume_id = gluster_volumes.id) THEN true
Line 2998:          ELSE false END 
Line 2999:          as is_master,
Line 3000:     CASE WHEN EXISTS (SELECT session_id FROM gluster_georep_session 
WHERE slave_volume_id = gluster_volumes.id) THEN true
Line 3001:          ELSE false END 
same
Line 3002:          as is_slave
Line 3003: FROM
Line 3004:     gluster_volumes
Line 3005: INNER JOIN vds_groups ON gluster_volumes.cluster_id = 
vds_groups.vds_group_id;


-- 
To view, visit https://gerrit.ovirt.org/38310
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28178b8ef03ea7cc83097cb99bc2d2be90061434
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to