Yevgeny Zaspitsky has posted comments on this change. Change subject: webadmin: Add managemenet network field to new/edit cluster dialog ......................................................................
Patch Set 34: (1 comment) https://gerrit.ovirt.org/#/c/37141/34/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java: Line 740: actionType = VdcActionType.UpdateVdsGroup; Line 741: if (model.isClusterDetached()) { Line 742: clusterOperationParameters = new ManagementNetworkOnClusterOperationParameters(cluster, managementNetworkId); Line 743: } else { Line 744: clusterOperationParameters = new ManagementNetworkOnClusterOperationParameters(cluster); > On the contrary, it would separate flows that are currently consolidated - The 2 different flows are one where management network being updated and another one where isn't. I'm not PM but if I would I'd drop the possibility of detached cluster and by that the option of updating management network through update cluster flow and then UpdateVdsGroupCommand would've stop taking management network id as it did prior that patch. Line 745: } Line 746: } Line 747: Frontend.getInstance().runAction( Line 748: actionType, -- To view, visit https://gerrit.ovirt.org/37141 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I055babd6037f127235c349499f1545396e38333f Gerrit-PatchSet: 34 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
