Moti Asayag has posted comments on this change. Change subject: engine: Updating the maintenance_reason on MaintenanceNumberOfVdssCommand ......................................................................
Patch Set 3: (3 comments) https://gerrit.ovirt.org/#/c/38298/3//COMMIT_MSG Commit Message: Line 17: mainternenceReason s/mainternenceReason/maintenanceReason https://gerrit.ovirt.org/#/c/38298/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetVdsStatusVDSCommandParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetVdsStatusVDSCommandParameters.java: Line 70: stopSpmFailureLogged=%s please add comma after stopSpmFailureLogged=%s, https://gerrit.ovirt.org/#/c/38298/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HostMonitoring.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HostMonitoring.java: Line 721: F why it is required to fetch the vds from the db ? have you noticed the reason is deleted from the db without refreshing the vds ? please use getDbFacade() -- To view, visit https://gerrit.ovirt.org/38298 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1ab2e0b3e2cc154d14282bc38b158b0b4d195fe Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
