Daniel Erez has uploaded a new change for review.

Change subject: webadmin: modify style of tables on storage domain dialog
......................................................................

webadmin: modify style of tables on storage domain dialog

Tune style of lun/target tables to prevent overflow.

Change-Id: Ic8100dc2231be08e046a03245cb9e7a181f4a4e3
Bug-Url: https://bugzilla.redhat.com/1141755
Signed-off-by: Daniel Erez <[email protected]>
---
M 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageLunToTargetList.java
M 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java
M 
frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/SanStorageListLunRoot.css
3 files changed, 6 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/62/38362/1

diff --git 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageLunToTargetList.java
 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageLunToTargetList.java
index 86561aa..a702ec1 100644
--- 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageLunToTargetList.java
+++ 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageLunToTargetList.java
@@ -71,7 +71,7 @@
             public String getValue(LunModel model) {
                 return ""; //$NON-NLS-1$
             }
-        }, "", "20px"); //$NON-NLS-1$ //$NON-NLS-2$
+        }, "", "15px"); //$NON-NLS-1$ //$NON-NLS-2$
 
         // Add last blank column
         table.addColumn(new TextColumn<LunModel>() {
@@ -112,7 +112,7 @@
             public String getValue(LunModel model) {
                 return ""; //$NON-NLS-1$
             }
-        }, multiSelection ? selectAllHeader : null, "27px"); //$NON-NLS-1$
+        }, multiSelection ? selectAllHeader : null, "20px"); //$NON-NLS-1$
     }
 
     final IEventListener<PropertyChangedEventArgs> 
lunModelSelectedItemListener = new IEventListener<PropertyChangedEventArgs>() {
@@ -148,7 +148,7 @@
                 return object;
             }
         };
-        table.setCustomSelectionColumn(lunSelectionColumn, "25px"); 
//$NON-NLS-1$
+        table.setCustomSelectionColumn(lunSelectionColumn, "20px"); 
//$NON-NLS-1$
 
         // Add items
         List<LunModel> items = new ArrayList<LunModel>();
diff --git 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java
 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java
index 63d0d02..378e989 100644
--- 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java
+++ 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java
@@ -74,7 +74,7 @@
             public String getValue(SanTargetModel model) {
                 return ""; //$NON-NLS-1$
             }
-        }, constants.empty(), "20px"); //$NON-NLS-1$
+        }, constants.empty(), "15px"); //$NON-NLS-1$
 
         table.addColumn(new AbstractScrollableTextColumn<SanTargetModel>() {
             @Override
diff --git 
a/frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/SanStorageListLunRoot.css
 
b/frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/SanStorageListLunRoot.css
index a89a4e4..d3436d5 100644
--- 
a/frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/SanStorageListLunRoot.css
+++ 
b/frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/SanStorageListLunRoot.css
@@ -1,4 +1,6 @@
 .cellTableWidget {
+    margin-left: 2px;
+    width: 99% !important;
 }
 
 .cellTableFirstColumn {


-- 
To view, visit https://gerrit.ovirt.org/38362
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic8100dc2231be08e046a03245cb9e7a181f4a4e3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to