Ramesh N has posted comments on this change. Change subject: engine: vds command to list storage devices ......................................................................
Patch Set 14: (3 comments) Patch set to follow https://gerrit.ovirt.org/#/c/35313/14/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetStorageDeviceListVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetStorageDeviceListVDSCommand.java: Line 4: import org.ovirt.engine.core.vdsbroker.vdsbroker.StatusForXmlRpc; Line 5: Line 6: public class GetStorageDeviceListVDSCommand<P extends VdsIdVDSCommandParametersBase> extends AbstractGlusterBrokerCommand<P> { Line 7: Line 8: private StorageDeviceListReturnForXmlRpc _result; > please maintain java naming convention Done Line 9: Line 10: public GetStorageDeviceListVDSCommand(P parameters) { Line 11: super(parameters); Line 12: } https://gerrit.ovirt.org/#/c/35313/14/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/StorageDeviceListReturnForXmlRpc.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/StorageDeviceListReturnForXmlRpc.java: > please use StringUtils.isNotBlank instead of !StringUtils.isBlank Done Line 1: package org.ovirt.engine.core.vdsbroker.gluster; Line 2: Line 3: import java.util.ArrayList; Line 4: import java.util.List; https://gerrit.ovirt.org/#/c/35313/14/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java: Line 1608: Line 1609: @Override Line 1610: public StorageDeviceListReturnForXmlRpc getStorageDeviceList() { Line 1611: JsonRpcRequest request = new RequestBuilder("GlusterHost.storageDevicesList").build(); Line 1612: Map<String, Object> response = new FutureMap(this.client, request).withIgnoreResponseKey(); > You expect no response key but in StorageDeviceListReturnForXmlRpc you look I will change it to .withResponseKey("deviceInfo"). Line 1613: return new StorageDeviceListReturnForXmlRpc(response); Line 1614: } -- To view, visit https://gerrit.ovirt.org/35313 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id47eadcb57d3f544481b577da7507f4fc9a10c67 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Timothy Asir <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
