Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: add Gluster Support ......................................................................
Patch Set 1: (3 comments) https://gerrit.ovirt.org/#/c/37662/1/src/ovirt_hosted_engine_setup/constants.py File src/ovirt_hosted_engine_setup/constants.py: Line 1 Line 2 Line 3 > you're right Done https://gerrit.ovirt.org/#/c/37662/1/src/plugins/ovirt-hosted-engine-setup/storage/nfs.py File src/plugins/ovirt-hosted-engine-setup/storage/nfs.py: Line 172: # TODO: check if a more informative message can be given Line 173: raise RuntimeError(response['status']['message']) Line 174: volumes = response['volumes'] Line 175: if volume not in volumes: Line 176: raise RuntimeError(_('GlusterFS Volume does not exist!')) > Make sense, I'll send a patch fixing master first. Done Line 177: if str(volumes[volume]['replicaCount']) != '3': Line 178: raise RuntimeError( Line 179: _( Line 180: 'GlusterFS Volume is not using replica 3' Line 248: def _customization(self): Line 249: if self.environment[ Line 250: ohostedcons.StorageEnv.DOMAIN_TYPE Line 251: ] == ohostedcons.DomainTypes.GLUSTERFS: Line 252: self.logger.warning( > .info imo is enough Done Line 253: _( Line 254: 'Please note that Replica 3 support is required for ' Line 255: 'the shared storage.' Line 256: ) -- To view, visit https://gerrit.ovirt.org/37662 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87f37cda3c9f957b548f7634ba143cf3f8a59ebe Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.2 Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
