Tomas Jelinek has uploaded a new change for review. Change subject: restapi: Allow creation of new disks as copy of any existing disk ......................................................................
restapi: Allow creation of new disks as copy of any existing disk Allowed to make a copy of a VM disk and allowed to set a new name of the cloned disk Bug-Url: https://bugzilla.redhat.com/1132066 Signed-off-by: Tomas Jelinek <[email protected]> Change-Id: I8931d2464d6ad17a80d9b394f16d01a2c47d7575 --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskResource.java 2 files changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/67/38367/1 diff --git a/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml b/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml index 36236a3..16d8b34 100644 --- a/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml +++ b/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml @@ -1215,6 +1215,7 @@ optionalArguments: action.async: xs:boolean action.grace_period.expiry: xs:long + action.name: xs:string description: copy a disk to a different storage domain urlparams: {} headers: diff --git a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskResource.java b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskResource.java index 6bced6c..b8f260a 100644 --- a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskResource.java +++ b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskResource.java @@ -10,6 +10,7 @@ import org.apache.commons.collections.CollectionUtils; import org.apache.commons.collections.MapUtils; +import org.apache.commons.lang.StringUtils; import org.ovirt.engine.api.model.Action; import org.ovirt.engine.api.model.Disk; import org.ovirt.engine.api.model.VM; @@ -103,6 +104,13 @@ sourceStorageDomainId, storageDomainId, ImageOperation.Copy); + + params.setImageGroupID(asGuid(disk.getId())); + + if (action.isSetName() && !StringUtils.isEmpty(action.getName())) { + params.setNewAlias(action.getName()); + } + return doAction(VdcActionType.MoveOrCopyDisk, params, action); } -- To view, visit https://gerrit.ovirt.org/38367 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8931d2464d6ad17a80d9b394f16d01a2c47d7575 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
