Alon Bar-Lev has posted comments on this change. Change subject: engine: add TerminateSession command ......................................................................
Patch Set 1: Code-Review-1 (1 comment) put my -1 per adding unnecessary complexity, feel free to ignore. https://gerrit.ovirt.org/#/c/38382/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/TerminateSessionCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/TerminateSessionCommand.java: Line 37: @Override Line 38: protected void executeCommand() { Line 39: LogoutUserParameters params = new LogoutUserParameters(user.getId()); Line 40: params.setSessionId(sessionId); Line 41: setReturnValue(Backend.getInstance().logoff(params)); > Indeed not part of this patch, and the week is almost over. this week is not about adding trash into the codebase, better to defer not to commit anything than add more bad implementation into the codebase. Line 42: } Line 43: Line 44: @Override Line 45: protected boolean isUserAuthorizedToRunAction() { -- To view, visit https://gerrit.ovirt.org/38382 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iebdc71abbd51d2eb01b2b3d9c877626d57d68d23 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
