Roy Golan has posted comments on this change. Change subject: core: add creation_date to permissions entity ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/38398/3/packaging/dbscripts/upgrade/03_06_0950_add_creation_date_to_permissions.sql File packaging/dbscripts/upgrade/03_06_0950_add_creation_date_to_permissions.sql: Line 1: SELECT fn_db_add_column('permissions', 'creation_date', 'bigint default (extract (epoch from now()))'); > Name should be "_create_date" like in other entities the _ prefix reads like it should be private or hidden. is that a matter of keep the convention with other fields? -- To view, visit https://gerrit.ovirt.org/38398 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iedaf56522fc2af4c4cc8da9f5c1c2572fe4de706 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
