Roy Golan has uploaded a new change for review. Change subject: webadmin: extract methods in permissionsListModel ......................................................................
webadmin: extract methods in permissionsListModel bring order and readability to the PermissionsListModel Change-Id: If910d6d2675f28e3d6c9c6df8e67f6801e2d42a5 Bug-Url: https://bugzilla.redhat.com/1080029 Signed-off-by: Roy Golan <[email protected]> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/permissions/PermissionListModelTable.java 1 file changed, 27 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/11/38411/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/permissions/PermissionListModelTable.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/permissions/PermissionListModelTable.java index fbbccda..961f627 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/permissions/PermissionListModelTable.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/permissions/PermissionListModelTable.java @@ -26,9 +26,23 @@ @Override public void initTable(CommonApplicationConstants constants) { getTable().enableColumnResizing(); + //add columns + addTypeColumn(constants); + addUserColumn(constants); + addAuthzColumn(constants); + addNameSpaceColumn(constants); + addRoleColumn(constants); + addCreationDateColum(constants); + // add buttons + addAddPermissionsButton(constants); + addRemovePermissionsButton(constants); + } + private void addTypeColumn(CommonApplicationConstants constants) { getTable().addColumn(new PermissionTypeColumn(), constants.empty(), "30px"); //$NON-NLS-1$ + } + private void addUserColumn(CommonApplicationConstants constants) { AbstractTextColumnWithTooltip<Permissions> userColumn = new AbstractTextColumnWithTooltip<Permissions>() { @Override public String getValue(Permissions object) { @@ -37,8 +51,9 @@ }; userColumn.makeSortable(); getTable().addColumn(userColumn, constants.userPermission(), "300px"); //$NON-NLS-1$ + } - + private void addAuthzColumn(CommonApplicationConstants constants) { AbstractTextColumnWithTooltip<Permissions> authzColumn = new AbstractTextColumnWithTooltip<Permissions>() { @Override public String getValue(Permissions object) { @@ -47,7 +62,9 @@ }; authzColumn.makeSortable(); getTable().addColumn(authzColumn, constants.authz(), "300px"); //$NON-NLS-1$ + } + private void addNameSpaceColumn(CommonApplicationConstants constants) { AbstractTextColumnWithTooltip<Permissions> namespaceColumn = new AbstractTextColumnWithTooltip<Permissions>() { @Override public String getValue(Permissions object) { @@ -56,7 +73,9 @@ }; namespaceColumn.makeSortable(); getTable().addColumn(namespaceColumn, constants.namespace(), "300px"); //$NON-NLS-1$ + } + private void addRoleColumn(CommonApplicationConstants constants) { AbstractTextColumnWithTooltip<Permissions> roleColumn = new AbstractTextColumnWithTooltip<Permissions>() { @Override public String getValue(Permissions object) { @@ -65,7 +84,9 @@ }; roleColumn.makeSortable(); getTable().addColumn(roleColumn, constants.rolePermission(), "300px"); //$NON-NLS-1$ + } + private void addCreationDateColum(CommonApplicationConstants constants) { AbstractTextColumnWithTooltip<Permissions> creationDateColumn = new AbstractTextColumnWithTooltip<Permissions>() { @Override public String getValue(Permissions object) { @@ -74,13 +95,18 @@ }; getTable().addColumn(creationDateColumn, constants.permissionsCreationDate(), "300px"); //$NON-NLS-1$ creationDateColumn.makeSortable(); + } + private void addAddPermissionsButton(final CommonApplicationConstants constants) { getTable().addActionButton(new UiCommandButtonDefinition<Permissions>(getEventBus(), constants.addPermission()) { @Override protected UICommand resolveCommand() { return getModel().getAddCommand(); } }); + } + + private void addRemovePermissionsButton(final CommonApplicationConstants constants) { getTable().addActionButton(new UiCommandButtonDefinition<Permissions>(getEventBus(), constants.removePermission()) { @Override protected UICommand resolveCommand() { -- To view, visit https://gerrit.ovirt.org/38411 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If910d6d2675f28e3d6c9c6df8e67f6801e2d42a5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
